Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findDOMNode is deprecated in StrictMode - error #1137

Open
CarelessCourage opened this issue Nov 10, 2022 · 7 comments · May be fixed by #1140
Open

findDOMNode is deprecated in StrictMode - error #1137

CarelessCourage opened this issue Nov 10, 2022 · 7 comments · May be fixed by #1140

Comments

@CarelessCourage
Copy link

Im getting this error with the combobox.

react_devtools_backend.js:4026 Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition2 which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here:

image

@bt
Copy link

bt commented Nov 29, 2022

Odd, I just came across this too with <DropdownList>. Similar stack trace, however it's mentioned in #928 that it's closed as fixed? No commit mentioned though and it was back in 2021 so it should have already been pushed.

@jquense
Copy link
Owner

jquense commented Nov 29, 2022

This is due to react-transition-group, I am going to try and work around it without breaking changes :/

@bt
Copy link

bt commented Dec 1, 2022

This is due to react-transition-group, I am going to try and work around it without breaking changes :/

Thanks for the quick reply. Would you mind sharing roughly what code uses this and maybe I'll have a look to see if I can help when I'm free?

@jquense
Copy link
Owner

jquense commented Dec 1, 2022

You can search in the repo, but probable the SlideDownTransition component specifically

@quinn
Copy link

quinn commented Jan 4, 2023

It looks like they may have added a workaround: https://github.com/reactjs/react-transition-group/blob/master/CHANGELOG.md#440-2020-05-05

@quinn quinn linked a pull request Jan 4, 2023 that will close this issue
@FlashAmarillo
Copy link

It looks like they may have added a workaround: https://github.com/reactjs/react-transition-group/blob/master/CHANGELOG.md#440-2020-05-05

how to add the useRef hook to the Combobox component to fix the same issue? @quinn

@robahtou
Copy link

running into this issue. any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants