Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uncontrollable): Migrate unsafe lifecycle #40

Merged
merged 7 commits into from
Oct 3, 2019
Merged

fix(uncontrollable): Migrate unsafe lifecycle #40

merged 7 commits into from
Oct 3, 2019

Conversation

nortonwong
Copy link
Contributor

@nortonwong nortonwong commented Sep 20, 2019 •
edited
Loading

Fixes #32.

@nortonwong nortonwong closed this Sep 20, 2019
@nortonwong nortonwong reopened this Sep 21, 2019
@slavagoreev
Copy link

Please, merge this PS asap. It is completely annoying to see those warnings!

@nortonwong nortonwong mentioned this pull request Sep 27, 2019
Closed
@MatthewHerbst
Copy link

I believe this requires bumping the React minimum version to ^16.3.0

@MatthewHerbst
Copy link

@jquense any chance we could fast-track merging this? Would help everyone who uses react-boostrap. This will be a breaking change to this library due to the peer dependency bump

@jquense
Copy link
Owner

jquense commented Oct 3, 2019

Given that fixing properly is a breaking change using https://github.com/reactjs/react-lifecycles-compat is probably a better first step as it doesn't require a major bump and any downstream consumers would automatically get the update.

I would suggest we do that first, release, and then remove bump the peer dep and cut a new major

@nortonwong
Copy link
Contributor Author

nortonwong commented Oct 3, 2019 •
edited
Loading

@jquense Looking at React's changelog, Hooks were introduced in 16.8.0. Since useUncontrolled() imports Hooks, it seems like a new minimum ^16.8.0 is needed anyway.

Alternately, you could publish a lifecycle-only branch without any bump. Thoughts?

@jquense
Copy link
Owner

jquense commented Oct 3, 2019

The minimum to use the hook is 16.8 yes, but not the HOC which is what is being updated here.

@nortonwong
Copy link
Contributor Author

Ah, so that can be left as a run-time error. Okay.

@jquense jquense merged commit 1607fff into jquense:master Oct 3, 2019
@jquense
Copy link
Owner

jquense commented Oct 3, 2019

awesome thanks!

jquense pushed a commit that referenced this pull request Oct 3, 2019
@semantic-release-bot
chore(release): 7.0.2 [skip ci]
6b33be7 
## [7.0.2](v7.0.1...v7.0.2) (2019-10-03)

### Bug Fixes

*  migrate unsafe lifecycle ([#40](#40)) ([1607fff](1607fff))
@jquense
Copy link
Owner

jquense commented Oct 3, 2019

🎉 This PR is included in version 7.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop using legacy lifecycle methods
4 participants
@nortonwong @slavagoreev @MatthewHerbst @jquense