fix: handle sparse array positions as undefined (#950)

* Handle sparse array positions as undefined

* Update src/array.js

Co-authored-by: Jason Quense <monastic.panic@gmail.com>

src/array.js

@@ -84,8 +84,11 @@ inherits(ArraySchema, MixedSchema, {
 
         originalValue = originalValue || value;
 
-        let validations = value.map((item, idx) => {
-          var path = makePath`${options.path}[${idx}]`;
+        // #950 Ensure that sparse array empty slots are validated
+        let validations = new Array(value.length);
+        for (let idx = 0; idx < value.length; idx++) {
+          let item = value[idx];
+          let path = makePath`${options.path}[${idx}]`;
 
           // object._validate note for isStrict explanation
           var innerOptions = {
@@ -97,10 +100,10 @@ inherits(ArraySchema, MixedSchema, {
             originalValue: originalValue[idx],
           };
 
-          if (innerType.validate) return innerType.validate(item, innerOptions);
-
-          return true;
-        });
+          validations[idx] = innerType.validate
+            ? innerType.validate(item, innerOptions)
+            : true;
+        }
 
         return runValidations({
           sync,

test/array.js

@@ -202,4 +202,20 @@ describe('Array types', () => {
       .of(itemSchema)
       .validate(value);
   });
+
+  it('should maintain array sparseness through validation', async () => {
+    let sparseArray = new Array(2);
+    sparseArray[1] = 1;
+    let value = await array().of(number()).validate(sparseArray);
+    expect(0 in sparseArray).to.be.false()
+    expect(0 in value).to.be.false()
+    // eslint-disable-next-line no-sparse-arrays
+    value.should.eql([,1]);
+  });
+
+  it('should validate empty slots in sparse array', async () => {
+    let sparseArray = new Array(2);
+    sparseArray[1] = 1;
+    await array().of(number().required()).isValid(sparseArray).should.become(false);
+  });
 });