Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default message for test with object #453

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

vonagam
Copy link
Contributor

@vonagam vonagam commented Feb 7, 2019

Two things:

  1. Fix. If you use test() with multiply arguments like test('name', func) then you will be provided with default message (locale.default). But not if you use it with opts object without message test(opts) or with second argument as undefined test('name', undefined, func) (it is assumed right now that since there are 3 arguments then message is present). Now all variants treated equally and if message is undefined then it will be set to locale.default.

  2. Small feature. Now it is possible to write test(func). Since name is needed only for exclusive tests it can be omitted (like it is possible to omit it in opts form).

@jquense jquense merged commit f1be37f into jquense:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants