Allow passing of function to .matches() options/message param #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if any updates are needed |
jquense
reviewed
Apr 22, 2020
src/string.js
Outdated
| @@ -77,6 +77,7 @@ inherits(StringSchema, MixedSchema, { | |||
|
|
|||
| if (options) { | |||
| if (typeof options === 'string') message = options; | |||
| if (typeof options === 'function') message = options; | |||
There was a problem hiding this comment.
I think this whole inner branch can be rewritten as
if (typeof options === 'object') {
({ excludeEmptyString, message, name } = options);
} else {
message = options
}There was a problem hiding this comment.
Thanks for the review, I had defaulted to checking it was a function as there was type checking for strings. The docs do show the supported types so it's really down to user error if they pass an incompatible type
There was a problem hiding this comment.
in practice, messages can be any type! The string check seems like a bug
There was a problem hiding this comment.
Perfect, have pushed the update, thanks again!
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across issue #849 this morning. Hopefully this closes #849