-
Notifications
You must be signed in to change notification settings - Fork 2.4k
1px jitter on the fixed footers under Android ICS + Chrome #4895
Comments
The fix that has been reverted is:
This was done because it would cause an incorrect min-height for the page, but I think the actual cause was something else (probably the updatePagePadding functionality). Downside of the fix is that the bottom border of the footer isn't visible. Not something you would notice when using the default theme but only if you create a custom theme with high contrast borders. |
@Wilto the 1px jitter isn't only an issue on Android ICS / Chrome, right? Shall we put the fix back in the code? |
I suggest to do the same for the header, because I've seen the issue at the top of the page as well. |
Turned out after some more testing that this is fix does cause an issue with the page height (vertical scrollbar appear) if you click to hide the toolbars (tapToggle). So this requires some more investigation to see what is the best way to fix it. |
Hey. Did u find a fix for the 1 pixel gap in bottom of the footer? I still have that issue. |
Working on it. See PR #4999 |
Fixes #4895 - 1px jitter on fixed toolbars
This fix is merged in master but not cherry-picked into 1.1 and 1.2 stable branches yet. Let's do some more testing first. |
On Nexus7 2px fixed it for me, not 1. |
I'm having this same issue, in a Cordova application only. I can set the bottom to a negative number and I see it going down but the line still exists and I can see page content through it. |
Referencing #3694 - the fix applied by @Wilto for 1.1 (and now in 1.2 RC) setting
.ui-footer-fixed
tobottom: 0
re-introduces the 1px gap consistently on ICS devices + Chrome with fixed footer toolbars. The stock Browser continues works correctly.This can be reproduced viewing the docs (tested with Motorola Droid and Galaxy Nexus).
http://jquerymobile.com/demos/1.2.0-alpha.1/docs/toolbars/bars-fixed.html
This fix is undoing the other fix that caused the document height to be oversized, which resorts to an undesirable device conditional:
Not sure there is a good choice since fixing one breaks the other and vice versa, just wanted to bring attention to it.
The text was updated successfully, but these errors were encountered: