Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in getFittedValues() that throws an error related to column names #116

Open
jr-leary7 opened this issue Sep 18, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@jr-leary7
Copy link
Owner

  • if you pass in a data frame to the cell.meta.data argument that contains a column named cell it conflicts with the creation of a column named cell internally, causing both to be renamed accidentally by dplyr
  • solution
    • check if a column named cell exists in the provided metadata, and if it does keep that column instead of the internal one before returning the results
@jr-leary7 jr-leary7 added the bug Something isn't working label Sep 18, 2023
@jr-leary7 jr-leary7 self-assigned this Sep 18, 2023
@jr-leary7 jr-leary7 changed the title fix bug in getFittedValues() that throws an error related to column named **cell** fix bug in getFittedValues() that throws an error related to column names Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant