Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation option ":if" is ignored #5

Open
bfolkens opened this issue Dec 8, 2009 · 0 comments
Open

validation option ":if" is ignored #5

bfolkens opened this issue Dec 8, 2009 · 0 comments

Comments

@bfolkens
Copy link

bfolkens commented Dec 8, 2009

I had a similar issue with the openid plugin since it uses the same logic.

For the validates_length_of_password_field_options, validates_confirmation_of_password_field_options, and validates_length_of_password_confirmation_field_options the :if option is ignored. It appears that a merge is executed against the options hash, overwriting the :if option. Can we change this to a reverse_merge? http://gist.github.com/251423

(I wanted to run this against the test suite but I couldn't get the suite to pass regardless of this patch's presence)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant