Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shellexpand final path in pick_search_path #128

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

satoqz
Copy link
Contributor

@satoqz satoqz commented Oct 24, 2024

The clone-repo and init-repo commands do not shell expand the search path they pick from the configuration via pick_search_path.

For example, my configuration is:

[[search_dirs]]
path = "~/src"

and below command:

tms clone-repo https://github.com/repo/repo

would result in the repo being cloned to $PWD/~/src/repo rather than /home/user/src/repo.

I'm assuming only the final search path that is picked in pick_search_path should be expanded such that the interactive picker still shows the unexpanded, easier to read paths first.

@jrmoulton
Copy link
Owner

Thanks!

@jrmoulton jrmoulton merged commit d82c7c9 into jrmoulton:main Oct 25, 2024
8 checks passed
@satoqz satoqz deleted the shell-expand-pick-search-path branch October 25, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants