clone-repo: Display clone repo progress
#139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configures whether to automatically switch to the new session after the `clone-repo` command finishes `Always` will always switch tmux to the new session `Never` will always create the new session in the background When set to `Foreground`, the new session will only be opened in the background if the active tmux session has changed since starting the clone process (for long clone processes on larger repos)
junglerobba
force-pushed
the
clone-repo-progress
branch
from
71e90d8 to
048535b
Compare
|
I think there is an easier way to do this https://docs.rs/git2/latest/git2/struct.RemoteCallbacks.html#method.transfer_progress |
|
I think that is what I am using, but I wanted to show an approximation of the current download speed, and I don’t think that is included there |
|
Oh whoops. Sorry I missed that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137
No idea if my calculation of the download rate is even slightly correct tbh, but it seems about right for the speeds that I usually get.
Didn't feel like including another crate just for one progress bar, so this is just a slightly scuffed one using block characters
I've noticed the need for the new config option because I've repeatedly cloned a very large repo while developing this, and sometimes switched to another session and then it would finish cloning in the background and rip me out of what I was currently doing somewhere else.