Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions to add VSCode as an external editor for Windows #1155

Closed
dheerajdlalwani opened this issue Jan 19, 2021 · 1 comment · Fixed by #1160
Closed

add instructions to add VSCode as an external editor for Windows #1155

dheerajdlalwani opened this issue Jan 19, 2021 · 1 comment · Fixed by #1160
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@dheerajdlalwani
Copy link

Documentation Change

Affected Page(s)

What Could Be Better?

I wanted to use VSCode as my external editor for jrnl. I did search online and the documentation. It lists how to set up VSCode as an external editor for MacOS and Linux but not for Windows. It would be really great if the step by step instructions for doing the same were added. Thank you :-)

Other Information

No.

@dheerajdlalwani dheerajdlalwani added the 🆕 New! label Jan 19, 2021
@micahellison micahellison added the documentation Improvements or additions to documentation label Jan 23, 2021
@micahellison micahellison self-assigned this Jan 23, 2021
@micahellison micahellison removed the 🆕 New! label Jan 23, 2021
@micahellison
Copy link
Member

Thanks for this issue! I've just got a pull request in to fix it, but in the meantime, the instructions are basically the same -- you need to add the --wait argument to your VS Code call, like so if it's in your PATH variable:

editor: 'code.exe --wait'

Or if it's not in your PATH, you'll need to refer to the whole path of VS Code (though this will not work until jrnl 2.7 due to bug #1096). For me that looks like:

editor: 'C:\Users\micah\AppData\Local\Programs\Microsoft VS Code\code.exe --wait'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants