Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python 3.6 #992

Closed
micahellison opened this issue Jul 4, 2020 · 1 comment · Fixed by #994
Closed

Deprecate Python 3.6 #992

micahellison opened this issue Jul 4, 2020 · 1 comment · Fixed by #994
Labels
deprecated Removed functionality or features

Comments

@micahellison
Copy link
Member

We're refactoring the argument parsing code and are using some functionality that isn't supported until Python 3.7 (ArgumentParser.parse_intermixed_args). It will be a while before this code goes live, but in the meantime, we should add a deprecation notice if users are running Python 3.6.

I don't think this should significantly inconvenience users. 3.6 is about four years old and 3.9 should come out in a few months. Homebrew uses 3.8 with jrnl, and Windows users don't have a default version to worry about.

@wren
Copy link
Member

wren commented Jul 10, 2020

Note to anyone reading this. The first version of jrnl that will require 3.7+ is v2.5.

v2.4.4-beta is coming out this weekend, and will be the last version of jrnl to support 3.6. Please update asap if you haven't already.

@wren wren closed this as completed in #994 Jul 12, 2020
@micahellison micahellison added the deprecated Removed functionality or features label Nov 14, 2020
@micahellison micahellison unpinned this issue Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated Removed functionality or features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants