Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEFOG Panel Schematic has incorrect footprints for LED's. #601

Closed
3 tasks done
Exprezz0 opened this issue Dec 7, 2022 · 3 comments · Fixed by #592
Closed
3 tasks done

DEFOG Panel Schematic has incorrect footprints for LED's. #601

Exprezz0 opened this issue Dec 7, 2022 · 3 comments · Fixed by #592
Assignees
Labels
Category: ECAD Electrical CAD/PCB HW Design Priority: Normal Type: Bug/Obsolesce Something isn't working/Part no longer available for sale

Comments

@Exprezz0
Copy link
Contributor

Exprezz0 commented Dec 7, 2022

Summary:

Due to limitations, the DEFOG Panel uses 3.5mm x 3.5mm LED's [*SK6812MINI] instead of the standard 5.0mm x 5.0mm LEDs [WS2812]. Currently, the footprints and symbols displayed on the both the schematic and PCB's are incorrect.

Issues:

1: Symbols displayed on the schematic don't match the footprint that they're assigned too. Symbol is WS2812, footprint is
SK6812MINI
2: Both the WS2812B series and SK6812 series have the same body size, but different pin arrangements.
3: JLCPCB doesn't have SK6812 series in Stock, but they have WS2812B-Mini.
4: Footprint displayed on PCB matches the WS2812B-Mini Footprint.

It looks like the footprint that's currently being used is a custom made footprint, pulling data from the WS2812B, but using the dimensions of the SK6812. The custom footprint is being called from OH_Backlighting footprint library, however it is not located in any library on the branch.

Expected Results/How It Should Work:

The LED symbol should be WS2812B-Mini with a matching footprint. The PCB should be updated with the same information. Once the schematic is updated, the LED information on the PCB can be updated without changing the paths.

Footprint should be located in custom Libraries folder.

Actual Results/How It Does Work:

The current footprint is LED_SK6812MINI_PLCC_3.5mmx3.5mm_P1.75mm

Screenshots:

More Information

Category:

Check one or more items.

  • ECAD (PCB Design or other electrical hardware)

Type:

Check one item.

  • Bug

Applicable End Item:

Check one item.

  • Right Console

Associated Filename(s):

ECAD\PCBs\OH_Specific\Backlighting_Type A\DEFOG Panel

@Exprezz0
Copy link
Contributor Author

Exprezz0 commented Dec 8, 2022

I reverted the DEFOG schematic to its original state. The confusion with the original issue was a mismatch of information within the schematic between the Symbol and Footprint it was using. It's my understanding that, due to prototype limitations, a 3.5mm by 3.5mm LED was being used instead of the standard 5.0mm by 5.0mm LED. In keeping with the same series, LED WS2812B-Mini would be used. However, the footprint and symbol for that specific LED doesn't exist in the Global directory.

To fix this, I believe luke used the SK6812-MINI footprint (which is located in the global directory) in place of the WS2812B-Mini footprint, as they both share the same dimensions. Even though the dimensions matched, the pin arrangement for both LEDs differed. Additionally, the LED name and LCSC part number listed on the schematic were also incorrect, which led to additional confusion. To make the confusion worse, the "custom footprint" that was being used was not located in the OH_backlighting library that is located in ECAD/PCB/OH_specific/backlighting/KiCad Files/OH_backlighing

Solution:

1: I've added the SK6812-mini footprint to the OH_Backlighting library, and renamed it WS2812B-Mini. I've checked the measurements against the datasheet (https://datasheetspdf.com/datasheet/WS2812B-Mini.html) and adjusted the footprint properties to reflect to the correct part number, name, and datasheet.

2: I've added the WS2812B-Mini Symbol to the Open hornet symbol library. Adjusted all properties/footprint to reflect.

3: I've replaced all of the LED Symbols and Footprints with the WS2812B-Mini. Nothing changed except naming properties, part number, and datasheet

Going to check the PCB tomorrow and make sure it receives the same information.

@jrsteensen jrsteensen linked a pull request Jan 31, 2023 that will close this issue
12 tasks
@jrsteensen jrsteensen added Type: Bug/Obsolesce Something isn't working/Part no longer available for sale Category: ECAD Electrical CAD/PCB HW Design Priority: Normal labels Mar 25, 2023
@jrsteensen jrsteensen added this to the v1.0.0-beta1 (Beta 1) milestone Mar 25, 2023
@Exprezz0
Copy link
Contributor Author

Double checked this: LED footprints were fixed with commit 62f2648 and updated in 29049d0. However, I just reviewed it and there's a few DRC errors that NEED to be fixed. Shouldn't effect any drawings, but I'm going to leave this open just in case LED's need to get swapped out.

@Exprezz0
Copy link
Contributor Author

Exprezz0 commented May 6, 2023

Reverified WS2812B, -Mini, & -2020 footprints with latest and greatest; added to libraries. Replaced existing footprints in PCB to be sure. Reannotated and rerouted PCB.

DRC are good, and manufacturing files and have recompiled and uploaded with commit 93cf242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: ECAD Electrical CAD/PCB HW Design Priority: Normal Type: Bug/Obsolesce Something isn't working/Part no longer available for sale
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants