Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JRubyExec should overwrite/clean the environment of RVM settings #90

Closed
rtyler opened this issue Dec 11, 2014 · 2 comments
Closed

JRubyExec should overwrite/clean the environment of RVM settings #90

rtyler opened this issue Dec 11, 2014 · 2 comments
Assignees
@rtyler
Labels
bug
Milestone
0.1.10

Comments

@rtyler
Copy link
Member

rtyler commented Dec 11, 2014

If you're using RVM, GEM_HOME and GEM_PATH can leak into JRubyExec tasks causing execution inconsistencies and hard to pin down bugs.

Ideally we should just scrub the System.environment of these values before spinning up the new JVM
@rtyler rtyler added the bug label Dec 11, 2014
@rtyler rtyler self-assigned this Dec 11, 2014
@rtyler rtyler added this to the 0.1.10 milestone Dec 11, 2014
@ysb33r
Copy link
Contributor

ysb33r commented Dec 11, 2014

I'm warming up to this, but qe cannit blindly remove the whole environment. So my suggestion is a boolean property rvmEnv. It is false by default which means RVM-related env varuables are removed before ececution.

@ysb33r
Copy link
Contributor

ysb33r commented Dec 11, 2014

To be clear, i meant is as a property on JRubyExec tasks, not on the JRuby extension.

@rtyler rtyler closed this as completed in 2d594c6 Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtyler rtyler

Labels
bug
Milestone
0.1.10
Development

No branches or pull requests
2 participants
@rtyler @ysb33r