Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computed properties #23

Closed
jmdobry opened this issue Jan 17, 2014 · 2 comments
Closed

Computed properties #23

jmdobry opened this issue Jan 17, 2014 · 2 comments

Comments

@jmdobry
Copy link
Member

jmdobry commented Jan 17, 2014

No description provided.

@jmdobry
Copy link
Member Author

jmdobry commented Jun 29, 2014

This will have to be handled with care because angular-data does not wrap items in custom classes or depend on the use of getters and setters. Computed properties will have to be updated during dirty checking loops. Angular-data runs its own dirty checking loop whenever a digest loop is triggered on the $rootScope. However, a digest loop triggered only on some child $scope won't trigger angular-data's dirty check. This could result in unexpected behavior as the computed property could be out of date. Of course, the developer can manually trigger angular-data's digest loop with DS.digest(), but I'd like to avoid developers' code being smattered with DS.digest calls.

@jmdobry
Copy link
Member Author

jmdobry commented Jun 29, 2014

Turns out, angular-data's hook into the $rootScope's digest cycle seems pretty reliable. I don't think there will be a problem here.

@jmdobry jmdobry mentioned this issue Jun 29, 2014
9 tasks
@jmdobry jmdobry added 3 - Done and removed 3 - Done labels Jun 29, 2014
@jmdobry jmdobry added this to the 0.10.0 milestone Jun 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant