Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BindOne recomputing computed properties #347

Closed
kenjiqq opened this issue Jan 5, 2016 · 1 comment
Closed

BindOne recomputing computed properties #347

kenjiqq opened this issue Jan 5, 2016 · 1 comment
Assignees

Comments

@kenjiqq
Copy link

kenjiqq commented Jan 5, 2016

Hi. We're in the process of upgrading to JSdata2. And we noticed that in the bindOne function you are recomputing computed properties but this is not happening in the bindAll function. So it seems to me that either it is required to recompute them and the bindAll function is wrong, or the bindOne function is running unneccery code.

let item = _this.get(resourceName, id)
if (item) {
  _this.compute(resourceName, id)
}
@jmdobry
Copy link
Member

jmdobry commented Jan 10, 2016

Probably needs to be added to bindAll.

@jmdobry jmdobry added the bug label Mar 18, 2016
@jmdobry jmdobry self-assigned this Mar 18, 2016
@jmdobry jmdobry added the done label Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants