Uncaught Type Error in viewer.js in package Web #999

[samuelwang48]

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Does your submission pass tests?

Note: please do NOT include build files (those generate by the build-xxx commands) with your PR,

Thank you for your help in advance, much appreciated !

[z3dev]

@samuelwang48 please revert the change to the jscad-web.min.js library. this is rebuilt during the release process, and shouldn't be part of code changes. thanks

you can just copy the latest from 'master', and commit that version. that should remove these changes.

[samuelwang48]

@samuelwang48 please revert the change to the jscad-web.min.js library. this is rebuilt during the release process, and shouldn't be part of code changes. thanks

you can just copy the latest from 'master', and commit that version. that should remove these changes.

Hi @z3dev the specific change aforementioned has been reverted. Feel free to let me know if there is anything else I can help. Thanks

[z3dev]

@samuelwang48 thanks for these changes, but i think another solution might be slightly better.

The viewer only supports the JSCAD geometries, so it's probably better just to filter the solids returned from the design, here... viewer.js, line 146

const solids = state.design.solids.filter((solid) => solid && (solid instanceof Object))

Thoughts?

[samuelwang48]

@samuelwang48 thanks for these changes, but i think another solution might be slightly better.

The viewer only supports the JSCAD geometries, so it's probably better just to filter the solids returned from the design, here... viewer.js, line 146

const solids = state.design.solids.filter((solid) => solid && (solid instanceof Object))

Thoughts?

Hi @z3dev, Thanks! I've made the changes accordingly. The said issue seems to have been solved. All tests passed.

[z3dev]

@samuelwang48 thanks. i hope this is the last time fixing this issue. ;)