Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to latest version of module serialize-to-js #457

Merged
merged 1 commit into from
Jul 28, 2019

Conversation

z3dev
Copy link
Member

@z3dev z3dev commented Jul 27, 2019

The serialize-to-js module was missing from the dependencies, which is required as part of the web flow functionality. As such, the require also had to change, as the module has recently gone through some API changes.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

Copy link
Contributor

@kaosat-dev kaosat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !
There is only one potential issue with that version: they removed the 'deserialize' function from the package, which we need in order to unpack the data (for now disabled, since it is tied to VTree changes...sigh). Will merge this.

@kaosat-dev kaosat-dev merged commit 84a9041 into V2 Jul 28, 2019
@z3dev z3dev deleted the fix-serialize-to-js branch November 7, 2019 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants