Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): replaced JSON comparisons with ID comparisons in viewer #839

Merged
merged 1 commit into from
May 16, 2021

Conversation

z3dev
Copy link
Member

@z3dev z3dev commented May 15, 2021

Small change... BIG performance boost, especially with large designs.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

Tested with Firefox, Chrome, and Safari

@z3dev
Copy link
Member Author

z3dev commented May 15, 2021

@hrgdavor How about reviewing these changes?

This is something that I have been working on for a few weeks, and finally decided that the JSON comparisons were inappropriate (and HUGE CPU / MEMORY hogs). Simple comparisons if 'id' is enough.

@z3dev z3dev requested review from mister-jscad and SimonClark May 15, 2021 06:06
Copy link
Contributor

@hrgdavor hrgdavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this will definitely help for large designs, and is better choice here.

This is something I will consider for the new web, as info on what was updated is crucial for the viewer to optimize rendering.

Copy link

@mister-jscad mister-jscad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes. Hope this helps performance.

@z3dev z3dev merged commit 87cc7d2 into master May 16, 2021
@z3dev z3dev deleted the fix-viewer-again branch May 29, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants