-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat : Enhance Renderer #863
Conversation
@hrgdavor Can you review these changes? FYI, demo.html will render the demo design properly AFTER 'npm run build'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, small change requested
This code is so nice and simple, it would be a good candidate for me to try-out OffscreenCanvas
If I put render and model evaluation both in same worker then there is no need for postMessage
|
That would be very cool. |
simple check like this should be sufficient if (typeof OffscreenCanvas !== "undefined") |
Definitely! I think this is the result of several months of hard work on the rendering. Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go.
These changes accomplish two things:
All demo applications work as expected. Test cases for regl-renderer all pass.
P.S. demo.html now becomes the simplest JSCAD application. :)
This includes a small change to the WEB UI viewer, which adds the drawLines command for initialization.
All Submissions: