Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : Enhance Renderer #863

Merged
merged 8 commits into from
Jun 15, 2021
Merged

Feat : Enhance Renderer #863

merged 8 commits into from
Jun 15, 2021

Conversation

z3dev
Copy link
Member

@z3dev z3dev commented Jun 11, 2021

These changes accomplish two things:

  • simplifying the draw commands, splitting out drawLines from drawMesh
  • adding simple event handing to demo.html, allowing the demo design to be rotated

All demo applications work as expected. Test cases for regl-renderer all pass.

P.S. demo.html now becomes the simplest JSCAD application. :)

This includes a small change to the WEB UI viewer, which adds the drawLines command for initialization.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

@z3dev
Copy link
Member Author

z3dev commented Jun 11, 2021

@hrgdavor Can you review these changes?

FYI, demo.html will render the demo design properly AFTER 'npm run build'.

Copy link
Contributor

@hrgdavor hrgdavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, small change requested

packages/utils/regl-renderer/demo.html Outdated Show resolved Hide resolved
@hrgdavor
Copy link
Contributor

This code is so nice and simple, it would be a good candidate for me to try-out OffscreenCanvas

  • with fallback
  • it is supported on most, but still not 100%

If I put render and model evaluation both in same worker then there is no need for postMessage

  • postMessage used when OffscreenCanvas is not supported.

@z3dev
Copy link
Member Author

z3dev commented Jun 11, 2021

This code is so nice and simple, it would be a good candidate for me to try-out OffscreenCanvas

  • with fallback
  • it is supported on most, but still not 100%

If I put render and model evaluation both in same worker then there is no need for postMessage

  • postMessage used when OffscreenCanvas is not supported.

That would be very cool.
Is there some way to detect the off screen canvas support?

@hrgdavor
Copy link
Contributor

That would be very cool.
Is there some way to detect the off screen canvas support?

simple check like this should be sufficient

if (typeof OffscreenCanvas !== "undefined")

@z3dev z3dev requested review from mister-jscad and SimonClark June 11, 2021 23:58
@z3dev
Copy link
Member Author

z3dev commented Jun 12, 2021

This code is so nice and simple,

Definitely! I think this is the result of several months of hard work on the rendering. Thanks a lot!

Copy link

@mister-jscad mister-jscad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@z3dev z3dev merged commit 02b5247 into master Jun 15, 2021
@z3dev z3dev mentioned this pull request Jun 20, 2021
@z3dev z3dev deleted the feat-enhance-renderer branch September 4, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants