Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix 917 missing json5 dependency #919

Merged
merged 4 commits into from
Sep 28, 2021
Merged

fix(core): fix 917 missing json5 dependency #919

merged 4 commits into from
Sep 28, 2021

Conversation

hrgdavor
Copy link
Contributor

@hrgdavor hrgdavor commented Sep 28, 2021 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

fix #917

z3dev
z3dev requested changes Sep 28, 2021
View reviewed changes
Copy link
Member

@z3dev z3dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! But let's remove the json5 dependency in the WEB package.

packages/core/package.json Outdated Show resolved Hide resolved
@hrgdavor hrgdavor requested a review from z3dev September 28, 2021 07:36
z3dev
z3dev approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@z3dev z3dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@z3dev z3dev merged commit 40d1cb1 into jscad:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z3dev z3dev z3dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing dependency json5 in npm package
2 participants
@hrgdavor @z3dev