Fix #189 - preload_metadata option on s3boto3 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like boto3 changed some keyword arguments and this prefix forgot to be captalised Signed-off-by: Leon Smith <_@leonmarksmith.com>
Current coverage is 59.97% (diff: 100%)@@ master #190 diff @@
==========================================
Files 17 17
Lines 1654 1654
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 992 992
Misses 662 662
Partials 0 0
|
|
Thanks, looks like it was caught in |
This was referenced Nov 8, 2016
This was referenced Dec 17, 2016
This was referenced Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like boto3 changed some keyword arguments and this prefix forgot to be capitalised