Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #118 #325

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Fix issue #118 #325

merged 1 commit into from
Jun 2, 2017

Conversation

sallyruthstruik
Copy link
Contributor

Fixed error described in #118

@codecov-io
Copy link

codecov-io commented Jun 2, 2017

Codecov Report

Merging #325 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   75.32%   75.38%   +0.06%     
==========================================
  Files          11       11              
  Lines        1552     1552              
==========================================
+ Hits         1169     1170       +1     
+ Misses        383      382       -1
Impacted Files Coverage Δ
storages/backends/sftpstorage.py 86.84% <100%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddcdf9e...d241378. Read the comment docs.

@jschneier
Copy link
Owner

Thanks for your contribution! This looks good although I sort of itch to want to remove this auto-adding at all.

@jschneier jschneier merged commit 5cce7c9 into jschneier:master Jun 2, 2017
@jschneier
Copy link
Owner

Note that there is a minor functionality change where a non-existent file could have been passed in and we'd fall back. I count that as a bug anyway so no big deal.

jschneier added a commit that referenced this pull request Jun 2, 2017
@sallyruthstruik
Copy link
Contributor Author

I found critical bug: when $HOME/.ssh/known hosts exists, whatever None is passed in load_known_hosts. Fixed in this PR: #330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants