-
-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #118 #325
Fix issue #118 #325
Conversation
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 75.32% 75.38% +0.06%
==========================================
Files 11 11
Lines 1552 1552
==========================================
+ Hits 1169 1170 +1
+ Misses 383 382 -1
Continue to review full report at Codecov.
|
Thanks for your contribution! This looks good although I sort of itch to want to remove this auto-adding at all. |
Note that there is a minor functionality change where a non-existent file could have been passed in and we'd fall back. I count that as a bug anyway so no big deal. |
I found critical bug: when $HOME/.ssh/known hosts exists, whatever None is passed in load_known_hosts. Fixed in this PR: #330 |
Fixed error described in #118