From 0e8199de0f4890309930659e402f7145545689e8 Mon Sep 17 00:00:00 2001 From: Edouard Bozon Date: Thu, 4 Feb 2021 09:52:01 +0100 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9E=20don't=20silently=20fail?= =?UTF-8?q?=20when=20error=20is=20an=20object?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Following this https://github.com/angular/angular-cli/issues/19951, the logger doesn't log when message is other type than string. --- packages/semver/src/builders/version/builder.ts | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/packages/semver/src/builders/version/builder.ts b/packages/semver/src/builders/version/builder.ts index e489c4ef3..31d2b4fd4 100644 --- a/packages/semver/src/builders/version/builder.ts +++ b/packages/semver/src/builders/version/builder.ts @@ -1,8 +1,4 @@ -import { - BuilderContext, - BuilderOutput, - createBuilder, -} from '@angular-devkit/architect'; +import { BuilderContext, BuilderOutput, createBuilder } from '@angular-devkit/architect'; import { concat, forkJoin, Observable, of } from 'rxjs'; import { catchError, mapTo, shareReplay, switchMap } from 'rxjs/operators'; @@ -10,11 +6,7 @@ import { VersionBuilderSchema } from './schema'; import { tryPushToGitRemote } from './utils/git'; import { tryBump } from './utils/try-bump'; import { getProjectRoot } from './utils/workspace'; -import { - CommonVersionOptions, - versionProject, - versionWorkspace, -} from './version'; +import { CommonVersionOptions, versionProject, versionWorkspace } from './version'; export function runBuilder( { @@ -79,7 +71,7 @@ export function runBuilder( return action$.pipe( mapTo({ success: true }), catchError((error) => { - context.logger.error(error); + context.logger.error(error.stack ?? error.toString()); context.reportStatus('Error'); return of({ success: false }); })