Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React v15 removed React.__spread #70

Closed
nil4 opened this issue Apr 7, 2016 · 4 comments
Closed

React v15 removed React.__spread #70

nil4 opened this issue Apr 7, 2016 · 4 comments

Comments

@nil4
Copy link

nil4 commented Apr 7, 2016

React v15 removed React.__spread and this change breaks everyone using csx-loader (see KyleAMathews/react-spinkit#28 for an example). It seems it will be added back temporarily but given the deprecation warning, it does not look like a good long-term solution.
@jsdf
Copy link
Owner

jsdf commented Apr 7, 2016

Thanks for letting me know. I think supporting __spread and Object.assign via a config option is probably the way to go

@nil4 nil4 mentioned this issue Apr 7, 2016
Closed
@nil4
Copy link
Author

nil4 commented Apr 7, 2016

FYI microsoft/TypeScript#7270 (comment):

We’ll temporarily bring it back [...]. However the method is deprecated and will go away in the next major release.

@KyleAMathews KyleAMathews mentioned this issue Apr 8, 2016
Closed
@DawidJanczak DawidJanczak mentioned this issue Apr 12, 2016
Merged
@KyleAMathews KyleAMathews mentioned this issue Apr 13, 2016
Closed
@abejfehr
Copy link

It looks like 4a4077a fixes this...can the updated version of this package be published to npm?

@jsdf
Copy link
Owner

jsdf commented Apr 18, 2016

Fixed in v4.0.0

@jsdf jsdf closed this as completed Apr 18, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nil4 @jsdf @abejfehr