Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot code push isn't working #95

Closed
occasl opened this issue Feb 27, 2018 · 2 comments
Closed

Hot code push isn't working #95

occasl opened this issue Feb 27, 2018 · 2 comments

Comments

@occasl
Copy link

occasl commented Feb 27, 2018

I notice you use --server-only in your build-meteor.sh, but from the Meteor docs it states:

You can pass --server-only to only build the server bundle. This allows you to build your app without installing the mobile SDKs on the build machine. This is useful if you use an automated deployment setup for instance. (If you remove the mobile platforms before building instead, hot code push will be disabled because the assets for Cordova included in the server bundle will not be generated.)

I'm seeing that the Docker image is built and deployed fine but when I try to open it with my mobile client, I'm not seeing the updates I made to the UI. Would this be the reason why?

I obviously would want hot code push, so thoughts on how to get this to work?

@jshimko
Copy link
Owner

jshimko commented Feb 27, 2018

Unfortunately, I won't be able to help you much here. I've never used Meteor's Cordova integration and don't really plan to any time soon (I'd personally use React Native before I'd try to use Cordova at this point). So I probably don't have much useful advice. However, based on the quote you pasted above, it sounds to me like hot code push should work as long as you don't remove the mobile stuff from .meteor/platforms.

The --server-only was definitely intentional here because any time a user with mobile builds set up in their project tried to do a Docker build, it would throw errors and fail because of the missing mobile SDK's and you couldn't ever complete a build of the server side. So that flag was only added so you can do a build without Xcode or the Android SDK installed.

@occasl
Copy link
Author

occasl commented Feb 27, 2018

The issue turns out to be with the mobile build. You have to add the port as the protocol seems to be ignored. Favor --server myserver.com:443 over https://myserver.com when building for mobile devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants