[jsk_fetch_startup] Add ros_google_cloud_language to fetch_bringup.launch #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sktometometo
requested changes
Apr 17, 2023
| @@ -408,6 +409,11 @@ | |||
| </rosparam> | |||
| </node> | |||
|
|
|||
| <include if="$(arg launch_google_analyze_text)" | |||
| file="$(find ros_google_cloud_language)/launch/analyze_text.launch"> | |||
| <arg name="google_cloud_credentials_json" value="/var/lib/robot/eternal-byte-236613-4bc6962824d1.json" /> | |||
There was a problem hiding this comment.
@tkmtnt7000 Can you upload this credential to GoogleDrive and add link to it here?
There was a problem hiding this comment.
Thank you. I added it in bc3dbd2.
sktometometo
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ros_google_cloud_launguageto default fetch_bringup.launch.This enables us to realize jsk-ros-pkg/jsk_demos#1388 in fetch robot every day.