Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "allowlist" and "blocklist" rather than "whitelist" #72

Closed
bnb opened this issue May 5, 2021 · 5 comments
Closed

Use "allowlist" and "blocklist" rather than "whitelist" #72

bnb opened this issue May 5, 2021 · 5 comments

Comments

@bnb
Copy link
Contributor

bnb commented May 5, 2021

The terminology "whitelist" and "blacklist" are used in a way that mean "good, blessed, permitted, positive" and "bad, forsaken, forbidden, negative" respectively. These are problematic in our society for reasons that are relatively obvious.

Instead, it would be preferable to use "allowlist" and "blocklist" or "allowlist" and "denylist" where the terminology is present.

I'm happy to submit a PR to make changes where relevant. I wanted to get a +1 from the maintainers via an Issue first, however, so as not to be particularly intrusive with a PR that is focusing on a negative.

If the use of spdx-whitelist is a blocker, I'm also happy to help do work there and in its upstream dependencies to update its terminology or help rename and republish it to spdx-allowlist or whatever other terminology that is preferred.

References on others doing this same thing/discussing the subject:

@ljharb
Copy link
Member

ljharb commented May 5, 2021

Renaming the dep seems the only thing that's particularly onerous; everything else can be done in a semver-minor or semver-patch way. I'm on board, even if it's for "everything but renaming the package".

@kemitchell?

@kemitchell
Copy link
Member

I have very little bandwidth ATM. @ljharb do you have perms to get this done?

@ljharb
Copy link
Member

ljharb commented May 5, 2021

I'm pretty sure I have merge perms everywhere needed, at least - if you're ok with it, I'll let @bnb put up the PRs, and I'll get them landed, and then if at that point I'm missing any permissions, I'll ping you here?

(hope you recover soon!)

@bnb
Copy link
Contributor Author

bnb commented May 5, 2021

Hope you feel better soon @kemitchell ❤️

@ljharb I'll get a PR up this week.

@bnb
Copy link
Contributor Author

bnb commented Jun 9, 2021

closing since #73 was merged :)

@bnb bnb closed this as completed Jun 9, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants