Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Support for type as array of strings #36

Open
BelfordZ opened this issue Jul 20, 2020 · 0 comments
Open

Drop Support for type as array of strings #36

BelfordZ opened this issue Jul 20, 2020 · 0 comments

Comments

@BelfordZ
Copy link
Member

BelfordZ commented Jul 20, 2020

The first json schema spec draft included type as array. It did not include anyOf, allOf, oneOf. These were never options at the time.

Now that they do exist, we have a feature multiplicity violation. That is, we have 2 ways of achieving ultimately the same thing, which is a mistake in any DSL.

What would change?

we would make the top level JSONMetaSchema schema into a oneOf: [ { type: "object" }, { type: "boolean" } ]
generated typings will now reflect the ability of a schema to be a boolean.

thats all. No user facing changes. All downstream libraries already support this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant