fix: read from stdin when resume path is a dash #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antialias
force-pushed
the
read-from-stdin-when-resume-path-is-dash
branch
from
f219ef8
to
6126f3e
Compare
added 4 commits
December 16, 2020 09:16
…ng memfs through IPC so it can be verified in tests
antialias
force-pushed
the
read-from-stdin-when-resume-path-is-dash
branch
from
6126f3e
to
1cec408
Compare
|
I'm going to merge this in 60 minutes since it fixes a regression and fixes some tests that were failing when run under CI. As usual, I'm happy to follow up with amendments after merge upon request. |
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than guessing if we have data on stdin, it's more reliable to set the "read resume from stdin" intention by making the resume path a dash.
This also fixes an issue with some ci tests.