-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when using relative local theme path it raises "TypeError: Cannot read property 'join' of undefined" #493
Comments
Having the same problem, however, using an absolute path also doesn't work for me, getting the following output
After adding resume naming
Gives back
Current working directory is identical to the error output above
Using this version the CLI
The theme in the folder is identical to the boilerplate theme, just started developing a custom theme. Not sure what's left to try, hopefully the PR gets merged soon |
What's the last functioning version to export a local theme that's still in development, and what command would I use? I reproduced the same error on 3.0.3, and 3.0.2/3.0.1/3.0.0 are giving me different errors. Or I guess I'll have to be patient for now. |
I too am facing the same problem. This problem is not visible on 3.0.0. I haven't tested it on 3.0.3, and 3.0.2/3.0.1. |
Any update on this? |
Still an issue on 3.0.4, freshly installed just now. Using an absolute path also fails as @hyperfocus1337 has found:
|
Still an issue for me as well, but the proposed fix #494 is still pending To be clear
My absolute path works only for the |
Applying the patch from #494 resolves the issue for me. Using Yarn’s patch protocol is one way of avoiding needing an official release, e.g. https://github.com/davidjb/cv/blob/master/package.json#L28 |
Env
node v14.15.4
resume-cli v3.0.4
Error
Expected behaviour
Providing relative local theme path (i.e
resume export --theme .
resume export --theme ../json-resume-theme-kendall/
should not raise error from within resume-cli lib.Full error stack
Hints
Due to recent changes (#469) when providing theme using
.
the path is not initialized inside render-html.jssee my comment on the changes directly
Temp fix
if you pass the theme without using relative path then it no longer crashes because
path.join
is not called on undefined object.with absolute path instead :
The text was updated successfully, but these errors were encountered: