fix(theme): fix serving and exporting local themes #537

XuluWarrior · 2021-03-15T21:33:25Z

Fixes #492, fixes #538.

XuluWarrior · 2021-03-15T21:39:44Z

lib/render-html.test.js

@@ -5,9 +5,6 @@ describe('renderHTML', () => {
    const originalRequireResolve = require.resolve;
    const mockThemePath = 'mock/path/to/jsonresume-theme-even';
    require.resolve = (...args) => {


While writing the new tests, I found that this mock of resolve is not called.
So tests are running against the actual file system.
Possibly the mock can be removed. Or maybe it needs to be fixed.

I propose to write that as a TODO comment instead of leaving as an PR comment.

The PR comment is an implicit question about what the correct action is.
Any TODO would come from the answer to the question.
And I'm not sure that in code TODOs is the way this project manages future code changes. They may prefer creating a GitHub issue.

XuluWarrior · 2021-03-15T22:10:25Z

lib/builder.js

@@ -3,7 +3,7 @@ const themeServer =
 const fs = require('fs');
 const request = require('superagent');
 const chalk = require('chalk');
-const renderHtml = require('./render-html');
+const renderHtml = require('./render-html').default;


This project uses a mix of CommonJS and ES6 modules. This should probably be made consistent to prevent bugs like this.
I won't address it in this PR.

wxsms · 2021-03-16T07:02:10Z

This solution works. thank you.

paskal · 2021-03-17T17:20:31Z

lib/render-html.test.js

@@ -43,5 +40,20 @@ describe('renderHTML', () => {
        '<!doctype html>',
      );
    });
+
+    it('should reject theme with invalid path', async () => {


According to what we see, currently, we don't test the theme with valid path, I wonder if that can be tested as well: some test which would be red without your alterations and green after them.

The test below ('with local theme path') is a valid path.
It would fail pre my changes.

My bad, I've missed that one. Looks good!

neviaumi · 2021-03-27T09:46:34Z

Can i kwon will it merge soon ?

michaltalaga · 2021-03-31T12:22:32Z

bump

XuluWarrior · 2021-03-31T12:38:06Z

Are there any project maintainers about to review/comment on this PR? I see that there haven't been any merges for a few months.

VCNinc · 2021-04-06T20:26:03Z

Is this project abandoned?

VCNinc · 2021-04-06T20:26:32Z

@thomasdavis

alexkreidler · 2021-05-03T15:05:45Z

I'm getting TypeError: renderHtml is not a function, it seems like this PR would fix that.

It would be great to get this merged. I'll ping the top commiters, so those who have commit rights and some free time can take a look: @rolandnsharp @thomasdavis @PeterDaveHello @rbardini @erming @antialias

Also if someone has time to run upgrade-interactive to bump the dependencies then you can close all the dependabot PRs.

Thanks all for this project!

paskal · 2021-06-09T12:15:12Z

Gentle ping @rolandnsharp @thomasdavis @PeterDaveHello @rbardini @erming @antialias

nhymxu · 2021-06-16T07:08:46Z

I don't have problem with local theme.
Just problem with const renderHtml = require('./render-html').default;

So, for clear and small PR. Should we split to two PR?

XuluWarrior · 2021-06-17T13:06:35Z

So now @paskal has approved this PR what is the next step?
Does it require further approval?
Or somebody with merge rights to do the merge?

paskal · 2021-06-17T13:10:22Z

I am no one here. Someone from the list above needs to approve and merge it.

github-actions · 2021-06-19T19:49:16Z

🎉 This PR is included in version 3.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

rbardini · 2021-06-19T20:05:49Z

Thanks @XuluWarrior for fixing this, and sorry everyone for the delay! As a side note, I've been writing an alternative JSON Resume builder from scratch that I hope might shape the future of resume-cli, in case anyone wants to give it a try 🙂

Issue with not loading local themes is now fixed jsonresume/resume-cli#537

… is now fixed jsonresume/resume-cli#537

Issue with not loading local themes is now fixed jsonresume/resume-cli#537

This reverts commit 16eae28.

)"" This reverts commit b24a94b.

XuluWarrior added 3 commits March 15, 2021 21:26

Fix using local theme from path

3edbd48

Duplicate if statement and spelling

7530932

Test local theme is loaded from path

ac94e1a

XuluWarrior force-pushed the fix-local-themes branch from 88f4262 to ac94e1a Compare March 15, 2021 21:37

XuluWarrior commented Mar 15, 2021

View reviewed changes

XuluWarrior mentioned this pull request Mar 15, 2021

Local themes broken again #538

Closed

Fix require('./render-html')

9e868d3

XuluWarrior commented Mar 15, 2021

View reviewed changes

XuluWarrior changed the title ~~Fix using local theme from path~~ fix: Fix using local theme from path Mar 15, 2021

XuluWarrior mentioned this pull request Mar 17, 2021

v3.0.3+: Can't serve resume from local theme #492

Closed

paskal reviewed Mar 17, 2021

View reviewed changes

paskal approved these changes Jun 9, 2021

View reviewed changes

rbardini approved these changes Jun 19, 2021

View reviewed changes

rbardini changed the title ~~fix: Fix using local theme from path~~ fix(theme): fix serving and exporting local themes Jun 19, 2021

rbardini merged commit 16eae28 into jsonresume:master Jun 19, 2021

github-actions bot added the released label Jun 19, 2021

XuluWarrior added a commit to XuluWarrior/jsonresume-theme-orbit that referenced this pull request Sep 1, 2023

Use resume-cli 3.0.8 in CI

e74ad11

Issue with not loading local themes is now fixed jsonresume/resume-cli#537

XuluWarrior mentioned this pull request Sep 1, 2023

Use resume-cli 3.0.8 in CI XuluWarrior/jsonresume-theme-orbit#87

Merged

XuluWarrior added a commit to XuluWarrior/jsonresume-theme-orbit that referenced this pull request Sep 23, 2023

fixup! Use resume-cli 3.0.8 in CI Issue with not loading local themes…

d434d67

… is now fixed jsonresume/resume-cli#537

XuluWarrior added a commit to XuluWarrior/jsonresume-theme-orbit-original that referenced this pull request Sep 23, 2023

Use resume-cli 3.0.8 in CI

62a3ce4

Issue with not loading local themes is now fixed jsonresume/resume-cli#537

XuluWarrior mentioned this pull request Sep 23, 2023

Use resume-cli 3.0.8 in CI XuluWarrior/jsonresume-theme-orbit-original#83

Merged

XuluWarrior added a commit to XuluWarrior/jsonresume-theme-orbit that referenced this pull request Sep 23, 2023

Use resume-cli 3.0.8 in CI

00c653e

Issue with not loading local themes is now fixed jsonresume/resume-cli#537

XuluWarrior added a commit to XuluWarrior/jsonresume-theme-kards that referenced this pull request Sep 23, 2023

Use resume-cli 3.0.8 in CI

e31e819

Issue with not loading local themes is now fixed jsonresume/resume-cli#537

XuluWarrior mentioned this pull request Sep 23, 2023

Use resume-cli 3.0.8 in CI XuluWarrior/jsonresume-theme-kards#92

Merged

thomasdavis added a commit that referenced this pull request Apr 3, 2024

Revert "fix(theme): fix serving and exporting local themes (#537)"

b24a94b

This reverts commit 16eae28.

thomasdavis added a commit that referenced this pull request Apr 3, 2024

Revert "Revert "fix(theme): fix serving and exporting local themes (#537

b35c324

)"" This reverts commit b24a94b.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(theme): fix serving and exporting local themes #537

fix(theme): fix serving and exporting local themes #537

XuluWarrior commented Mar 15, 2021 •

edited by rbardini

Loading

XuluWarrior Mar 15, 2021

paskal Mar 17, 2021

XuluWarrior Mar 31, 2021

XuluWarrior Mar 15, 2021

wxsms commented Mar 16, 2021

paskal Mar 17, 2021 •

edited

Loading

XuluWarrior Mar 17, 2021 •

edited

Loading

paskal Mar 17, 2021

neviaumi commented Mar 27, 2021

michaltalaga commented Mar 31, 2021

XuluWarrior commented Mar 31, 2021

VCNinc commented Apr 6, 2021

VCNinc commented Apr 6, 2021

alexkreidler commented May 3, 2021

paskal commented Jun 9, 2021

nhymxu commented Jun 16, 2021

XuluWarrior commented Jun 17, 2021

paskal commented Jun 17, 2021

github-actions bot commented Jun 19, 2021

rbardini commented Jun 19, 2021

fix(theme): fix serving and exporting local themes #537

fix(theme): fix serving and exporting local themes #537

Conversation

XuluWarrior commented Mar 15, 2021 • edited by rbardini Loading

XuluWarrior Mar 15, 2021

Choose a reason for hiding this comment

paskal Mar 17, 2021

Choose a reason for hiding this comment

XuluWarrior Mar 31, 2021

Choose a reason for hiding this comment

XuluWarrior Mar 15, 2021

Choose a reason for hiding this comment

wxsms commented Mar 16, 2021

paskal Mar 17, 2021 • edited Loading

Choose a reason for hiding this comment

XuluWarrior Mar 17, 2021 • edited Loading

Choose a reason for hiding this comment

paskal Mar 17, 2021

Choose a reason for hiding this comment

neviaumi commented Mar 27, 2021

michaltalaga commented Mar 31, 2021

XuluWarrior commented Mar 31, 2021

VCNinc commented Apr 6, 2021

VCNinc commented Apr 6, 2021

alexkreidler commented May 3, 2021

paskal commented Jun 9, 2021

nhymxu commented Jun 16, 2021

XuluWarrior commented Jun 17, 2021

paskal commented Jun 17, 2021

github-actions bot commented Jun 19, 2021

rbardini commented Jun 19, 2021

XuluWarrior commented Mar 15, 2021 •

edited by rbardini

Loading

paskal Mar 17, 2021 •

edited

Loading

XuluWarrior Mar 17, 2021 •

edited

Loading