-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themes are missing company names #620
Comments
I just noticed this today as well. I distinctly remember it working before, so this bug was recently introduced. |
Quick fix, in your "work": [
{
"company": "Facebook",
"startDate": "1999-03-10",
"position": "Software Consulting",
"summary": "Lorem ipsum software development and consulting."
},
... would become "work": [
{
"name": "Facebook",
"startDate": "1999-03-10",
"position": "Software Consulting",
"summary": "Lorem ipsum software development and consulting."
},
... Here's the actual cause of the problem: the website schema uses "company" as the field name, while the actual schema definition uses "name". Not sure why there is a discrepancy, will try to put in a pull request to fix if I get the chance 🤷 |
I think this should do the trick? Pull request |
hello @adewinter, yes I made sure the work object uses the name keyword instead of the company. However, the opposite fixed the issue. For my setup, I changed the keyword from name to company. Now it works...???? Edit: reran |
This is because it depends on the theme. Later I'll see which ones are still accepting PRs and submit one to accept the new names for properties, and fallback to the old name. |
I have tried numerous themes with a clean letter size pdf, but nearly all of them is unable to generate the company name.
node version: v14.17.2
Win10 21H1
Attached are screen shots of the pages served through
resume serve --theme [theme name]
The text was updated successfully, but these errors were encountered: