Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloned themes as git submodules, installed them, but can't export as PDF? #685

Closed
Nezteb opened this issue Mar 15, 2022 · 2 comments · Fixed by #689
Closed

Cloned themes as git submodules, installed them, but can't export as PDF? #685

Nezteb opened this issue Mar 15, 2022 · 2 comments · Fixed by #689

Comments

@Nezteb
Copy link
Contributor

Nezteb commented Mar 15, 2022

I made a themes directory and then added two themes to it as git submodules:

  • git submodule add git@github.com:davcd/jsonresume-theme-actual.git themes/actual
  • git submodule add git@github.com:kelyvin/jsonresume-theme-caffeine.git themes/caffeine

Directory structure:

❯ tree -L 2
.
├── README.md
├── example.json
├── index.html
├── node_modules
│   └── ...
├── package-lock.json
├── package.json
├── public
│   └── index.html
├── resume.json
├── resume.pdf
├── themes
│   ├── actual
│   └── caffeine
└── yarn.lock

I cd'd into each theme directory and ran npm install, each command succeeded, then went back to the root. I tried running npm install ./themes/actual for each theme from the root too.

HTML exports work fine for both themes using: resume export --theme ./themes/actual index.html

However, PDF does not work when running: resume export --theme ./themes/actual resume.pdf.

When I run it, I get the following error regardless of the theme:

You have to install this theme relative to the folder to use it e.g. 'npm install /Users/nezteb/Git/resume/index.js'

Using Node version 12.22.6 (I tried with 16 and got lots of Node/GYP errors when installing each theme).

@chessmango
Copy link

Related: #408 (comment)
I haven't tested specifying a theme manually (as that's what that issue covers and what was at least semi-fixed) - I'm using even because it's pretty and gets the job done :P but that worked with 3.0.5 as expected, before the fix above at least

@Nezteb
Copy link
Contributor Author

Nezteb commented Apr 10, 2022

Here is a PR to fix this issue: #689

Testing locally it works with my above setup ^.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants