fix(deps): bump puppeteer to ^16.1.0, fix Apple Silicon installation
#730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes chromium installation issues on Apple Silicon machines
|
Whoops, looks like the M1 issue was already fixed in an unmerged PR: #612 @thomasdavis - Hate to pester, but can this PR (or something similar) be expedited for the arm64 folks? |
dorupopacaliman
approved these changes
Oct 20, 2022
|
@rbardini Can we please merge this? |
|
🎉 This PR is included in version 3.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes chromium installation issues on Apple Silicon machines. Jest tests appear to pass, and I was able to render my personal
resume.jsonto pdf on an M1 MacBook Pro after upgrading.Note: I had to completely remove
node_modulesand runnpm iagain after bumping to get puppeteer to install chromium.Users may have previously hacked their puppeteer installations via
~/.zshrclike so:Those users may need to remove those two lines, start a new terminal emulator tab/instance, and re-install
resume-clito get the deps resolved.