Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload called on scroll in iOS Safari #818

Closed
jamiesarakinis opened this issue Mar 3, 2017 · 3 comments
Closed

Reload called on scroll in iOS Safari #818

jamiesarakinis opened this issue Mar 3, 2017 · 3 comments

Comments

@jamiesarakinis
Copy link

In the plugin initialization, reload is called on window resize events. In iOS Safari, resize events are called on page scroll, which is causing the carousel to behave undesirably in some circumstances. I've handled this by removing the $(window).on('resize.jcarousel', this.onWindowResize) call from the create function, but it may be useful to include an option to disable this behavior

@jsor
Copy link
Owner

jsor commented Mar 8, 2017

Thanks for the report. I've pushed a fix in 3f180bc which checks if the window dimension actually changed. Could you test the patch and report back if that fixes the issue? Thanks!

@jamiesarakinis
Copy link
Author

Thanks, that has fixed the issue

@jsor
Copy link
Owner

jsor commented Mar 15, 2017

Thanks for the confirmation. Fix released in 0.3.5.

@jsor jsor closed this as completed Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants