From f702f627a2afdbce0184b5bcad66be969ae8aa6e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?ArielRen=C3=A9e?= Date: Thu, 6 Aug 2020 14:11:20 -0700 Subject: [PATCH 1/8] [readme] add Spanish translation See #726. --- README.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 5ccebc172..54cb6ab56 100644 --- a/README.md +++ b/README.md @@ -26,6 +26,12 @@ Static AST checker for accessibility rules on JSX elements. + + +#### *Read this in [other languages](https://github.com/ari-os310/eslint-plugin-jsx-a11y/blob/master/translations/Translations.md).* + +[Mexican Spanish🇲🇽](https://github.com/ari-os310/eslint-plugin-jsx-a11y/blob/master/translations/README.mx.md) + ## Why? Ryan Florence built out this awesome runtime-analysis tool called [react-a11y](https://github.com/reactjs/react-a11y). It is super useful. However, since you're probably already using linting in your project, this plugin comes for free and closer to the actual development process. Pairing this plugin with an editor lint plugin, you can bake accessibility standards into your application in real-time. @@ -80,7 +86,6 @@ Then configure the rules you want to use under the rules section. } ``` - You can also enable all the recommended or strict rules at once. Add `plugin:jsx-a11y/recommended` or `plugin:jsx-a11y/strict` in `extends`: From 3d98d7a03a55fb165e3bf868acc927f48199e13c Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Tue, 6 Oct 2020 23:55:20 -0700 Subject: [PATCH 2/8] [Deps] update `@babel/runtime`, `axe-core` --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 839877b6d..4dc34f190 100644 --- a/package.json +++ b/package.json @@ -58,11 +58,11 @@ }, "license": "MIT", "dependencies": { - "@babel/runtime": "^7.10.2", + "@babel/runtime": "^7.11.2", "aria-query": "^4.2.2", "array-includes": "^3.1.1", "ast-types-flow": "^0.0.7", - "axe-core": "^3.5.4", + "axe-core": "^3.5.5", "axobject-query": "^2.2.0", "damerau-levenshtein": "^1.0.6", "emoji-regex": "^9.0.0", From eb92b071efa1c76f6690f7e6d07d4b6c2e8ba29f Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Tue, 6 Oct 2020 23:57:01 -0700 Subject: [PATCH 3/8] [Dev Deps] update `@babel/cli`, `@babel/core`, `@babel/plugin-transform-flow-strip-types`, `eslint-plugin-flowtype`, `eslint-plugin-import`, `estraverse`, `expect`, `object.assign` --- package.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index 4dc34f190..39f105849 100644 --- a/package.json +++ b/package.json @@ -30,25 +30,25 @@ "jest": "jest --coverage __tests__/**/*" }, "devDependencies": { - "@babel/cli": "^7.10.1", - "@babel/core": "^7.10.2", - "@babel/plugin-transform-flow-strip-types": "^7.10.1", + "@babel/cli": "^7.11.6", + "@babel/core": "^7.11.6", + "@babel/plugin-transform-flow-strip-types": "^7.10.4", "babel-eslint": "^10.1.0", "babel-jest": "^24.9.0", "babel-preset-airbnb": "^5.0.0", "coveralls": "^3.1.0", "eslint": "^3 || ^4 || ^5 || ^6 || ^7", "eslint-config-airbnb-base": "^14.2.0", - "eslint-plugin-flowtype": "^5.1.3", - "eslint-plugin-import": "^2.21.2", - "estraverse": "^5.0.0", - "expect": "^24.3.1", + "eslint-plugin-flowtype": "^5.2.0", + "eslint-plugin-import": "^2.22.1", + "estraverse": "^5.2.0", + "expect": "^24.9.0", "flow-bin": "^0.113.0", "in-publish": "^2.0.1", "jest": "^24.9.0", "jscodeshift": "^0.7.0", "minimist": "^1.2.5", - "object.assign": "^4.1.0", + "object.assign": "^4.1.1", "rimraf": "^3.0.2", "safe-publish-latest": "^1.1.4", "to-ast": "^1.0.0" From 83e4ff28705875d8d28afd0791784a62ac5d77fd Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Wed, 7 Oct 2020 00:09:39 -0700 Subject: [PATCH 4/8] [Deps] update `axe-core`, `jsx-ast-utils` --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 39f105849..96c1c6d08 100644 --- a/package.json +++ b/package.json @@ -62,12 +62,12 @@ "aria-query": "^4.2.2", "array-includes": "^3.1.1", "ast-types-flow": "^0.0.7", - "axe-core": "^3.5.5", + "axe-core": "^4.0.2", "axobject-query": "^2.2.0", "damerau-levenshtein": "^1.0.6", "emoji-regex": "^9.0.0", "has": "^1.0.3", - "jsx-ast-utils": "^2.4.1", + "jsx-ast-utils": "^3.0.0", "language-tags": "^1.0.5" }, "peerDependencies": { From a6d883d4c63e37de70fd92e6ff89561f2a90b0eb Mon Sep 17 00:00:00 2001 From: Jesse Renee Beach Date: Sun, 11 Oct 2020 21:58:40 -0700 Subject: [PATCH 5/8] CHANGELOG update for v6.4.0 6.4.0 --- CHANGELOG.md | 23 +++++++++++++++++++++++ package.json | 2 +- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a10c40d7a..31cb54fd3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,26 @@ +6.4.0 / 2020-10-26 +================== + +- 83e4ff2 [Deps] update `axe-core`, `jsx-ast-utils` +- eb92b07 [Dev Deps] update `@babel/cli`, `@babel/core`, `@babel/plugin-transform-flow-strip-types`, `eslint-plugin-flowtype`, `eslint-plugin-import`, `estraverse`, `expect`, `object.assign` +- 3d98d7a [Deps] update `@babel/runtime`, `axe-core` +- f702f62 [readme] add Spanish translation +- c2ae092 [Docs] `no-static-element-interactions`: Fixed rule name in comments +- b90e20d Fix screenreader -> screen reader +- 645900a Fixed rule name in comments +- 381b9d6 [fix:634] Ignore control elements that are hidden +- 2c47f0a [Fix] `autocomplete-valid`: workaround for axe not being able to handle `null` +- 00bd6d8 Add failing test for autocomplete with dynamic type +- 3c49c9a Add WCAG guidelines to rule documentation +- 4ecaf35 Add a testcase for tablist to interactive supports focus +- dac6864 Deprecate the accessible-emoji rule +- 5191053 Update to axobject-query@2.2.0 +- b315698 Allow negative tabindex in aria-activedescendant-has-tabindex +- 8e6fcd0 docs: fix travis badge now points to correct location at travis-ci.com +- 2234df7 Account for additional control elements in label-has-associated-control +- 5cbb718 Adding test cases for label tests +- 66c425c Additional test case for no-redundant-roles + 6.3.1 / 2020-06-19 ================== diff --git a/package.json b/package.json index 96c1c6d08..c703f208b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "eslint-plugin-jsx-a11y", - "version": "6.3.1", + "version": "6.4.0", "description": "Static AST checker for accessibility rules on JSX elements.", "keywords": [ "eslint", From f8a4496b55b113ae835d04a7d4300b824a4a4680 Mon Sep 17 00:00:00 2001 From: Jesse Renee Beach Date: Sun, 25 Oct 2020 22:31:57 -0700 Subject: [PATCH 6/8] Upgrade jsx-ast-utils to v3.1.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index c703f208b..b0ee7c994 100644 --- a/package.json +++ b/package.json @@ -67,7 +67,7 @@ "damerau-levenshtein": "^1.0.6", "emoji-regex": "^9.0.0", "has": "^1.0.3", - "jsx-ast-utils": "^3.0.0", + "jsx-ast-utils": "^3.1.0", "language-tags": "^1.0.5" }, "peerDependencies": { From c99beef4f30c3dd3d4a11dd9b0727caa4bb37d5e Mon Sep 17 00:00:00 2001 From: Jesse Renee Beach Date: Sun, 25 Oct 2020 22:33:28 -0700 Subject: [PATCH 7/8] 6.4.1 --- CHANGELOG.md | 4 ++++ package.json | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 31cb54fd3..e6b58ee28 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +6.4.1 / 2020-10-26 +================== +- f8a4496 Upgrade jsx-ast-utils to v3.1.0 + 6.4.0 / 2020-10-26 ================== diff --git a/package.json b/package.json index b0ee7c994..cf6c08719 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "eslint-plugin-jsx-a11y", - "version": "6.4.0", + "version": "6.4.1", "description": "Static AST checker for accessibility rules on JSX elements.", "keywords": [ "eslint", From 20b48a4110fef62165148a43269d955d82882cbc Mon Sep 17 00:00:00 2001 From: Karl Horky Date: Tue, 17 Nov 2020 20:04:49 +0100 Subject: [PATCH 8/8] [patch] `no-onchange`: Remove rule from recommended/strict configs, and deprecate See https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/398#issuecomment-729113622 --- docs/rules/no-onchange.md | 4 +++- src/index.js | 2 -- src/rules/no-onchange.js | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/rules/no-onchange.md b/docs/rules/no-onchange.md index 5c4875c77..01eedd100 100644 --- a/docs/rules/no-onchange.md +++ b/docs/rules/no-onchange.md @@ -1,4 +1,6 @@ -# no-onchange +# [Deprecated] no-onchange + +⚠️ **Deprecated:** This rule is based on reports of behavior of [old browsers (eg. IE 10 and below)](https://www.quirksmode.org/dom/events/change.html#t05). In the meantime, this behavior has been corrected, both in newer versions of browsers as well as [in the DOM spec](https://bugzilla.mozilla.org/show_bug.cgi?id=969068#c2). Enforce usage of `onBlur` over/in parallel with `onChange` on select menu elements for accessibility. `onBlur` **should** be used instead of `onChange`, unless absolutely necessary and it causes no negative consequences for keyboard only or screen reader users. `onBlur` is a more declarative action by the user: for instance in a dropdown, using the arrow keys to toggle between options will trigger the `onChange` event in some browsers. Regardless, when a change of context results from an `onBlur` event or an `onChange` event, the user should be notified of the change unless it occurs below the currently focused element. diff --git a/src/index.js b/src/index.js index 4bec05cb5..2b1f4c4c8 100644 --- a/src/index.js +++ b/src/index.js @@ -175,7 +175,6 @@ module.exports = { allowExpressionValues: true, }, ], - 'jsx-a11y/no-onchange': 'error', 'jsx-a11y/no-redundant-roles': 'error', 'jsx-a11y/no-static-element-interactions': [ 'error', @@ -283,7 +282,6 @@ module.exports = { ], 'jsx-a11y/no-noninteractive-element-to-interactive-role': 'error', 'jsx-a11y/no-noninteractive-tabindex': 'error', - 'jsx-a11y/no-onchange': 'error', 'jsx-a11y/no-redundant-roles': 'error', 'jsx-a11y/no-static-element-interactions': 'error', 'jsx-a11y/role-has-required-aria-props': 'error', diff --git a/src/rules/no-onchange.js b/src/rules/no-onchange.js index 9451b57d0..06486bf7c 100644 --- a/src/rules/no-onchange.js +++ b/src/rules/no-onchange.js @@ -24,6 +24,7 @@ module.exports = { docs: { url: 'https://github.com/evcohen/eslint-plugin-jsx-a11y/tree/master/docs/rules/no-onchange.md', }, + deprecated: true, schema: [schema], },