-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme doesn't say where the "settings" should be placed #2169
Comments
Yes, in eslintrc, and at the top level (see https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb/rules/react.js#L470 for an example). What version of eslint do you have? |
5.14.1 |
If you downgrade to 5.14.0 or 5.13, do you still see the problem? |
Well, I agree that adding in the README where it should be located helps. |
The ordering shouldn’t matter; JSON schema, which eslint uses to validate its config, doesn’t care about order. |
Maybe it has to appear after “react” in the plugins dir tho, so that it can be made valid? |
This led me on a bit of a chase around for a bit too. An explicit note that It would also be helpful to know if what's shown is the effective default if you don't set anything yourself. |
@samsch a PR to improve the docs would be appreciated, both here and in eslint core. The options are shown on our readme. |
in the README.md there's the following sentence
but it doesn't say where you would place these settings. Is it .eslintrc? If so, where in the structure? I tried top level but I get
The text was updated successfully, but these errors were encountered: