Teach prop-types about destructing in function signatures #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following should cause an error for missing propType validations,
but it doesn't.
const Test = ({ name }) => {
return (
<div>{name}</div>
);
};
If you replace the destructuring with using the props object, it works
as expected. This commit fixes this problem.
Fixes jsx-eslint#354.
lencioni
force-pushed
the
stateless-destructured-prop-types
branch
from
686bcb3 to
59f26d7
Compare
|
(ﾉ◕ヮ◕)ﾉ*:・ﾟ✧ awesome! |
yannickcr
added a commit
that referenced
this pull request
Feb 7, 2016
Add support to prop-types for destructing in function signatures (fixes #354)
|
Merged, thanks! |
|
@yannickcr yay! version bump soon? :-D |
|
Thanks! If you are thinking about releasing a new version, it would be really swell if #429 could sneak in it as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following should cause an error for missing propType validations,
but it doesn't.
If you replace the destructuring with using the props object, it works
as expected. This commit fixes this problem.
Fixes #354.