Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvement: suggestion #6

Open
colisee opened this issue Jul 6, 2023 · 2 comments
Open

Documentation improvement: suggestion #6

colisee opened this issue Jul 6, 2023 · 2 comments

Comments

@colisee
Copy link

colisee commented Jul 6, 2023

Hi,

the documentation does not mention how to generate source and binary (which is the default behavior for dpkg-buildpackage)

This is the github action code I used in that respect:

jobs:
  build-debs:
    runs-on: ubuntu-latest
    steps:
      -
        name: checkout
        uses: actions/checkout@v3
        with:
          fetch-depth: '0'
      -
        name: build-deb-amd64
        uses: jtdor/build-deb-action@v1
        env:
          DEB_BUILD_OPTIONS: noautodbgsym
        with:
          buildpackage-opts: --build=full
          extra-build-deps: pristine-tar git
          before-build-hook: pristine-tar checkout ../$(pristine-tar list)
          host-arch: amd64
      -
        name: upload
        uses: actions/upload-artifact@v3
        with:
          path: debian/artifacts/
          name: debian_package

Note:

  • I assume the repository to be checked out has a pristine-tar branch that contains the upstream tarball delta
  • I check out all branches of the repository with the argument fetch-depth: 0
  • I install additional packages with extra-build-deps: pristine-tar git
  • I specify the argument buildpackage-opts: --build=full

Feel free to add the above to your documentation, if you feel it could be of use.

Cheers.

@jtdor
Copy link
Owner

jtdor commented Jul 25, 2023

Hi @colisee,

thank you for the suggestion!

Originally I wanted to keep the documentation short here and mainly refer to the documentations of dpkg-buildpackage and the other involved tools. But I see that it would be helpful to show more than just the most trivial use case in the action’s readme, as it’s currently done.

Will think about how to present your use case (thanks for the code) and maybe others. Will keep this issue open for now as a reminder to myself.

In case you find any problems with other use cases, please let me know!

@colisee
Copy link
Author

colisee commented Jul 26, 2023

Hi @jtdor,

This is the least I could do!

For your information, you can find the full github action (which uses a matrix strategy) here

Please note that I modified the before-build-hook argument in my action because I had several tars listed by the command pristine tar checkout. As a reminder, the pristine command works if your git repository contains a pristine-tar branch (in my case generated through git-buildpackage)

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants