Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate Cloud Run support #135

Merged
merged 20 commits into from
Sep 13, 2021
Merged

Conversation

jthegedus
Copy link
Owner

@jthegedus jthegedus commented Sep 12, 2021

Summary

  • deprecates Cloud Run support as Cloud Functions now support minInstances - https://firebase.google.com/docs/functions/manage-functions#min-max-instances
    • this leaves concurrency and region as the only core features differing between CF & CR on Firebase
  • fix include .region("us-central1") in CLI logged Cloud Function code
  • remove cloudRunBuildDir
  • remove validation of Cloud Run regions
  • rename option firebaseJson to firebaseJsonPath
  • remove husky
  • bump SvelteKit to @sveltejs/kit@1.0.0-next.165

Fixes: #118

PR is marked as feat as it is a breaking change

@jthegedus jthegedus merged commit ee5d92a into main Sep 13, 2021
@jthegedus jthegedus deleted the feat/deprecate-cloudrun-support branch September 13, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Deprecate Cloud Run support
1 participant