Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compute esbuild target from Function runtime version #137

Merged
merged 14 commits into from
Sep 16, 2021
Merged

feat: compute esbuild target from Function runtime version #137

merged 14 commits into from
Sep 16, 2021

Conversation

jthegedus
Copy link
Owner

@jthegedus jthegedus commented Sep 14, 2021 •
edited
Loading

Summary

  • feat: use provided Function runtime Node.js version in esbuild target config. Enabled by
    • chore: utils.ensureCompatibleCloudFunctionVersion returns runtime version
  • chore: remove hints/codes
  • chore: remove kleur CLI formatter & rely on SvelteKit Adapter utils
  • chore: remove typescript dep
  • chore: bump Kit peer dep to minimum of 1.0.0-next.168
  • chore: bump esbuild dep to minimum of 0.12.28
  • docs: show how to target ESM output with esbuild
  • fix: unit tests

todo

  • ensure error messages can be seen by users who do not enable the --verbose flag when running svelte-kit build.

@jthegedus jthegedus changed the title feat: simplify codebase feat: compute esbuild target from Function runtime version Sep 16, 2021
@jthegedus jthegedus merged commit 61f2b3b into main Sep 16, 2021
@jthegedus jthegedus deleted the feat/simplify-codebase branch September 16, 2021 09:57
@jthegedus jthegedus mentioned this pull request Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jthegedus