Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missed rename of hostingSite to target, bump kit for types #149

Merged
merged 4 commits into from
Oct 10, 2021
Merged

fix: missed rename of hostingSite to target, bump kit for types #149

merged 4 commits into from
Oct 10, 2021

Conversation

jthegedus
Copy link
Owner

@jthegedus jthegedus commented Oct 10, 2021 •
edited
Loading

Summary

  • the default options for the adapter did not have hostingSite renamed to target during refactor.
    • fix error by renaming var (and fixing TS types)
    • test to capture error in future?
  • bump svelte/kit to 1.0.0-next'180

Fixes: #148

Other Information

@jthegedus jthegedus changed the title fix: rename of hostingsite to target, bump kit for types fix: missed rename of hostingSite to target, bump kit for types Oct 10, 2021
@jthegedus jthegedus merged commit cebf821 into main Oct 10, 2021
@jthegedus jthegedus deleted the fix/hostingsite-rename branch October 10, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: target property is not being applied correctly
1 participant
@jthegedus