From e11d45581a01751a6e8561928c7cf8721e767b04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Ferreira?= Date: Wed, 29 May 2024 17:49:36 +0100 Subject: [PATCH] remove a few more java.net.URL --- .../librarymanagement/ComponentManager.scala | 5 +---- .../internal/librarymanagement/ConvertResolver.scala | 12 ++++++------ .../internal/librarymanagement/FakeResolver.scala | 4 ++-- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/ivy/src/main/scala/sbt/internal/librarymanagement/ComponentManager.scala b/ivy/src/main/scala/sbt/internal/librarymanagement/ComponentManager.scala index 710c120d..7f84c3bf 100644 --- a/ivy/src/main/scala/sbt/internal/librarymanagement/ComponentManager.scala +++ b/ivy/src/main/scala/sbt/internal/librarymanagement/ComponentManager.scala @@ -101,7 +101,7 @@ object IfMissing { object ComponentManager { lazy val (version, timestamp) = { val properties = new java.util.Properties - val propertiesStream = versionResource.openStream + val propertiesStream = getClass.getResourceAsStream("/xsbt.version.properties") try { properties.load(propertiesStream) } finally { @@ -110,7 +110,4 @@ object ComponentManager { (properties.getProperty("version"), properties.getProperty("timestamp")) } lazy val stampedVersion = version + "_" + timestamp - - import java.net.URL - private def versionResource: URL = getClass.getResource("/xsbt.version.properties") } diff --git a/ivy/src/main/scala/sbt/internal/librarymanagement/ConvertResolver.scala b/ivy/src/main/scala/sbt/internal/librarymanagement/ConvertResolver.scala index 33b55ab8..54a8537e 100644 --- a/ivy/src/main/scala/sbt/internal/librarymanagement/ConvertResolver.scala +++ b/ivy/src/main/scala/sbt/internal/librarymanagement/ConvertResolver.scala @@ -3,7 +3,7 @@ */ package sbt.internal.librarymanagement -import java.net.URL +import java.net.URI import java.util.Collections import org.apache.ivy.core.module.descriptor.DependencyDescriptor @@ -355,17 +355,17 @@ private[sbt] object ConvertResolver { private[this] val repo = new WarnOnOverwriteFileRepo() private[this] val progress = new RepositoryCopyProgressListener(this); override def getResource(source: String) = { - val url = new URL(source) - if (url.getProtocol == IO.FileScheme) + val url = new URI(source) + if (url.getScheme == IO.FileScheme) new FileResource(repo, IO.toFile(url)) else super.getResource(source) } override def put(source: File, destination: String, overwrite: Boolean): Unit = { - val url = new URL(destination) + val uri = new URI(destination) try { - if (url.getProtocol != IO.FileScheme) super.put(source, destination, overwrite) + if (uri.getScheme != IO.FileScheme) super.put(source, destination, overwrite) else { // Here we duplicate the put method for files so we don't just bail on trying ot use Http handler val resource = getResource(destination) @@ -378,7 +378,7 @@ private[sbt] object ConvertResolver { if (totalLength > 0) { progress.setTotalLength(totalLength); } - FileUtil.copy(source, new java.io.File(url.toURI), progress, overwrite) + FileUtil.copy(source, new java.io.File(uri), progress, overwrite) () } catch { case ex: IOException => diff --git a/ivy/src/main/scala/sbt/internal/librarymanagement/FakeResolver.scala b/ivy/src/main/scala/sbt/internal/librarymanagement/FakeResolver.scala index df4a7d66..00c0275a 100644 --- a/ivy/src/main/scala/sbt/internal/librarymanagement/FakeResolver.scala +++ b/ivy/src/main/scala/sbt/internal/librarymanagement/FakeResolver.scala @@ -1,7 +1,7 @@ package sbt import java.io.File -import java.net.URL +import java.net.URI import org.apache.ivy.core.cache.ArtifactOrigin import org.apache.ivy.core.cache.{ DefaultRepositoryCacheManager, RepositoryCacheManager } @@ -69,7 +69,7 @@ private[sbt] class FakeResolver(private var name: String, cacheDir: File, module ): ArtifactDownloadReport = { val report = new ArtifactDownloadReport(artifact.getArtifact) - val path = new URL(artifact.getLocation).toURI.getPath + val path = new URI(artifact.getLocation).getPath val localFile = new File(path) if (path.nonEmpty && localFile.exists) {