-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow an animation not to require an explicit restart after the target is reached then updated again. #13
Comments
Hey @Clafou, I'm glad to hear you're enjoying Wave! To confirm, the idea you're proposing is that with this flag enabled, any time a property animation's I'm open to this, but would like to understand the benefits/use-case more. It seems that it would just eliminate a call to |
Hi Janum, thanks for the response. Yes, my suggestion is to make it possible to change For example, say you have an animation that depends on a scrollview's offset, which the end user controls by swiping. For the client code it makes sense to create a property animation, start it, and simply update |
Hey @Clafou! Sorry for the delay here -- I agree with this proposal and will post a patch soon. |
This framework is great and I found it easy to replace Facebook pop – thank you!
One minor issue I have is that animations automatically stop when the target value is reached, then become inactive. Any further change to the target value is ignored until the animation is explicitly restarted. But an app may not care whether the animation has reached its target and may just want to animate changes by updating the target.
Facebook pop has a
removedOnCompletion
property to address this and keep animations alive when set to false. Would it be possible to add something similar?The text was updated successfully, but these errors were encountered: