Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: must put shift keys in defsrc to highlight on a layer #858

Closed
1 task done
brandonbeaumia opened this issue Mar 19, 2024 · 3 comments
Closed
1 task done

Bug: must put shift keys in defsrc to highlight on a layer #858

brandonbeaumia opened this issue Mar 19, 2024 · 3 comments
Assignees
Labels
blocked Blocked on issues outside of the reasonable control of the kanata project bug Something isn't working llhook Pertains to the standard version of Kanata on Windows windows Issue pertains to Windows only

Comments

@brandonbeaumia
Copy link
Contributor

Requirements

Describe the bug

When using a config that does not have lshift/rshift in defsrc, navigation keys (arrows/pgdn/etc) used within a layer do not highlight while holding shift.

Relevant kanata config

(defsrc 
    caps h j k l
)

(deflayer base
    @nav h j k l
)

(deflayer navlayer
    @base left down up right
)

(defalias base (layer-switch base))
(defalias nav (layer-switch navlayer))

To Reproduce

  1. Set config to above.
  2. Press caps to switch layers.
  3. Hold shift and press navigation keys.

Expected behavior

Text should highlight in the direction of navigation.

Kanata version

kanata v1.6.0-prerelease-1

Debug logs

No response

Operating system

Windows 11

Additional context

Easily worked around after learning the fix, but have not run across documentation about this behavior. Unless fixable, add a note to config.adoc's defsrc entry?

@brandonbeaumia brandonbeaumia added the bug Something isn't working label Mar 19, 2024
@jtroo jtroo added windows Issue pertains to Windows only llhook Pertains to the standard version of Kanata on Windows labels Mar 21, 2024
@jtroo
Copy link
Owner

jtroo commented Mar 21, 2024

Thanks, I wasn't aware of this issue!

To clarify, you're using the default binary and not the interception/wintercept variant right?

@brandonbeaumia
Copy link
Contributor Author

Correct, just kanata.exe from releases.

@jtroo jtroo added the blocked Blocked on issues outside of the reasonable control of the kanata project label Mar 22, 2024
@jtroo jtroo closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2024
@jtroo
Copy link
Owner

jtroo commented Mar 23, 2024

Added documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on issues outside of the reasonable control of the kanata project bug Something isn't working llhook Pertains to the standard version of Kanata on Windows windows Issue pertains to Windows only
Projects
None yet
Development

No branches or pull requests

2 participants