Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more verbose logging for cmd #633

Merged
merged 3 commits into from
Nov 17, 2023
Merged

feat: more verbose logging for cmd #633

merged 3 commits into from
Nov 17, 2023

Conversation

rszyma
Copy link
Contributor

@rszyma rszyma commented Nov 16, 2023

Describe your changes. Use imperative present tense.

I feel like current logging for cmd action is not enough. This PR fixes it.

Checklist

  • Add documentation to docs/config.adoc
    • N/A
  • Add example and basic docs to cfg_samples/kanata.kbd
    • N/A
  • Update error messages
    • Yes
  • Added tests, or did manual testing
    • Manual testing

@rszyma
Copy link
Contributor Author

rszyma commented Nov 16, 2023

Inspired by #632

jtroo
jtroo reviewed Nov 16, 2023
View reviewed changes
src/kanata/cmd.rs Outdated Show resolved Hide resolved
@jtroo jtroo merged commit 84a7931 into jtroo:main Nov 17, 2023
3 checks passed
@rszyma rszyma deleted the cmd-logging branch November 23, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtroo jtroo jtroo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rszyma @jtroo