Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error code undefined #10

Closed
jamierytlewski opened this issue Aug 12, 2014 · 9 comments
Closed

Error code undefined #10

jamierytlewski opened this issue Aug 12, 2014 · 9 comments

Comments

@jamierytlewski
Copy link

If I use scss-lint TechSmithSass/*.scss everything is just fine. I'm on scss-lint .26 and gulp-scss-lint .11

gulp.task('scss-lint', function(){
  gulp.src('TechSmithSass/*.scss')
    .pipe(scsslint());
});
[10:59:28] Using gulpfile ~/GitHub/PublicWebProperties/gulpfile.js
[10:59:28] Starting 'scss-lint'...
[10:59:28] Finished 'scss-lint' after 4.3 ms

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error in plugin 'gulp-scss-lint'
Error code undefined
    at /Users/j.rytlewski/GitHub/PublicWebProperties/node_modules/gulp-scss-lint/src/index.js:58:32
    at ChildProcess.exithandler (child_process.js:643:7)
    at ChildProcess.emit (events.js:98:17)
    at maybeClose (child_process.js:755:16)
    at Process.ChildProcess._handle.onexit (child_process.js:822:5)
@juanfran
Copy link
Owner

What happens if you run this on the path where you have the gulpfile?

scss-lint TechSmithSass/*.scss --format XML

@jamierytlewski
Copy link
Author

Shows me the proper XML.

@juanfran
Copy link
Owner

I can not reproduce the error. Could you add console.log(error); after line 53?

exec(command, function (error, report) {
    console.log(error);
...

@jamierytlewski
Copy link
Author

I apologize for the delay. [Error: stdout maxBuffer exceeded.]

@finteractive
Copy link

I too have the same error which appears after I upgraded my scss-lint gem from 0.25.1 to 0.27.0. My config is essentially identical with the 'bundleExec': true parameter set. gulp-scss-lint is version 0.1

Reverting the gem to 25.1 fixes the error.

bundle exec scss-lint sass/*.scss --format XML
returns

<?xml version="1.0" encoding="utf-8"?><lint></lint>



@jamierytlewski
Copy link
Author

ahmednuaman/grunt-scss-lint#63 - think this needs to be changed, that's what grunt-scss-lint had to do.

@juanfran
Copy link
Owner

Thanks, I added the maxBuffer option

@davidnknight
Copy link

Setting maxBuffer to false made no difference for me, however, setting it to 524288 worked, which I came across in sun-zheng-an/gulp-shell#13.

Two questions. Firstly, why isn't false working? Secondly, why is there no config example for the maxBuffer option in the readme, yet there is for every other option? Whilst an obvious assumption is to just add maxBuffer to the scsslint config, i.e. scsslint({maxBuffer: false}), it did make me question whether I had put it in the right place when false wasn't working.

For the sake of consistency in the documentation, and also to remove any possible need to make assumptions and cause needless confusion, I'd add it. Also probably an idea to explain what the maxBuffer integer actually is and a suggested range rather than just saying "number", which explains nothing and could result in a user questioning "number of what?" "0 or 1?" "Is this talking about memory allowed to execute? What's the default value which clearly isn't enough? Is it measured in bytes or mb?" and so on. A little elaboration on this could help others to avoid having to hunt for answers, like I did.

@juanfran
Copy link
Owner

Sorry for my mistakes in the documentation

Thanks for your suggestions, I have made some changes.

I removed the false option because doesn't work how I expected. (and I had a bug)
I removed the default node value in the maxBuffer option and set it to 307200.
I updated the documentation, now with the other two changes I think It's clear enough.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants