Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.22 #4339

Closed
Tracked by #157782
stefanb opened this issue Jan 14, 2024 · 1 comment · Fixed by #4340
Closed
Tracked by #157782

Support Go 1.22 #4339

stefanb opened this issue Jan 14, 2024 · 1 comment · Fixed by #4340
Assignees
Labels
kind/bug Something isn't working

Comments

@stefanb
Copy link
Contributor

stefanb commented Jan 14, 2024

What happened:

Fails to build with Go 1.22 (scheduled for February, currently at rc1)

Error log: https://github.com/Homebrew/homebrew-core/actions/runs/7284497233/job/19850411474#step:3:11882

  # github.com/pyroscope-io/godeltaprof/internal/pprof
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/pyroscope-io/godeltaprof@v0.1.2/internal/pprof/delta_mutex.go:25:20: undefined: runtime_cyclesPerSecond
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/pyroscope-io/godeltaprof@v0.1.2/internal/pprof/proto.go:400:8: undefined: runtime_expandFinalInlineFrame
  make: *** [juicefs] Error 1

What you expected to happen:

Build same as with Go 1.21

How to reproduce it (as minimally and precisely as possible):

  1. Install Go 1.22 rc1
  2. Try to build with go1.22rc1 build ./...

Anything else we need to know?

Environment:

  • JuiceFS version (use juicefs --version) or Hadoop Java SDK version:
  • Cloud provider or hardware configuration running JuiceFS:
  • OS (e.g cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Object storage (cloud provider and region, or self maintained):
  • Metadata engine info (version, cloud provider managed or self maintained):
  • Network connectivity (JuiceFS to metadata engine, JuiceFS to object storage):
  • Others:
@stefanb stefanb added the kind/bug Something isn't working label Jan 14, 2024
@zhijian-pro zhijian-pro self-assigned this Jan 15, 2024
@stefanb
Copy link
Contributor Author

stefanb commented Jan 15, 2024

Note that once this is fixed it would still need a tagged release so that it can easily be picked up by Homebrew/homebrew-core#157782 and others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants