-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows issues #75
Comments
i used to use browser-launcher2 but switched back to browser-launcher because that was working better for most cases. i'm happy to merge something in if it works well, but currently don't have time to work on this on my own. out of curiosity, what windows version are you running? |
I use Vista. I would upgrade if I could, but the update is so expensive... But anyway, if you look at the windows browser detection code, it's really fragile. Do you remember the issue you had with browser-launcher2? |
i just looked through the history and it seems like this never actually used browser-launcher2. i'd be happy to accept a pull request to move to that. |
I'm trying to do that but I am annoyed because I can't even run the tests. First, there is the makefile: I've replaced it by regular npm scripts. Then, many tests fail: all the tests using electron fail on my machine, that's not really surprising, but also phantomjs, spawn, and stream ones! Don't know if I'll have time to fix that too. Note that I installed phantomjs globally, so phantomjs tests should probably work... For the record, here are the errors I get:
|
You could set up a Linux Vm for running this project, so you have a good starting point. This error |
First thing you should probably do in every dependent library: use cross-spawn instead of child_process.spawn. See nodejs/node-v0.x-archive#5841 |
This might fix at least the phantom test issue for you: #79 |
I try to use tape-run but can't because I have many issues on my Windows box:
Can I suggest moving to browser-launcher2 instead of browser-launcher, so that bugs are fixed?
The text was updated successfully, but these errors were encountered: